Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-13575][LLD, LLM][MyLedger]: Filtering of apps depending on feature flag #7542

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Aug 7, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • My Ledger app catalog

πŸ“ Description

Fix & refactor the logic of "is app supported by Ledger Live" depending on feature flags, as well as associated filters in apps catalog.
Now this logic is in one single place and fully unit tested.

The main issue addressed is that for apps that associated to a currency with a feature flag, those apps were totally gone from the catalog if the feature flag was disabled, which shouldn't be the case. The correct behaviour is to filter out those apps only when the filter "Supported in Live" is selected.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ofreyssinet-ledger ofreyssinet-ledger requested a review from a team as a code owner August 7, 2024 14:56
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Aug 7, 2024 4:22pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 4:22pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 4:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 4:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 4:22pm

@ofreyssinet-ledger ofreyssinet-ledger merged commit 8b928c6 into develop Aug 8, 2024
61 of 62 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/LIVE-13575-myledger-apps-filter branch August 8, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants